Skip to content

Improve parsing in await and yield context#44680

Merged
sandersn merged 4 commits into
microsoft:mainfrom
Kingwl:improve_binding_identifier_parsing_new
Jun 22, 2021
Merged

Improve parsing in await and yield context#44680
sandersn merged 4 commits into
microsoft:mainfrom
Kingwl:improve_binding_identifier_parsing_new

Conversation

@Kingwl

@Kingwl Kingwl commented Jun 21, 2021

Copy link
Copy Markdown
Contributor

Fixes #44459
Close #44464 for case sensitive issue.

@Kingwl

Kingwl commented Jun 21, 2021

Copy link
Copy Markdown
Contributor Author

Try deleting it from isIdentifier

You can see this commit. Seems not feel better.
It is worth noting that the emitted code has changed. So it's might a breaking change.

If that doesn't work out, put a small comment

Done.

@sandersn sandersn merged commit fafe3ff into microsoft:main Jun 22, 2021
@Kingwl

Kingwl commented Jun 22, 2021

Copy link
Copy Markdown
Contributor Author

@typescript-bot pack this.

@typescript-bot

typescript-bot commented Jun 22, 2021

Copy link
Copy Markdown
Contributor

Heya @Kingwl, I've started to run the tarball bundle task on this PR at 23cd5e9. You can monitor the build here.

@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

For Backlog Bug PRs that fix a backlog bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Binding identifier should care about await/yield context

3 participants